Error if an autodiff user does not set lto=fat #148855
Merged
+44
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rustbot
added
A-LLVM
This comment has been minimized.
This comment has been minimized.
ZuseZ4
changed the title
ZuseZ4
changed the title
Member
Author
|
r? @bjorn3 |
Collaborator
|
Failed to set assignee to
|
ZuseZ4
force-pushed
the
autodiff-lto-error
branch
from
b097bb6 to
370542e
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
ZuseZ4
force-pushed
the
autodiff-lto-error
branch
from
370542e to
9b84ba2
Compare
This comment has been minimized.
This comment has been minimized.
ZuseZ4
force-pushed
the
autodiff-lto-error
branch
from
9b84ba2 to
b07b6fa
Compare
This comment has been minimized.
This comment has been minimized.
ZuseZ4
force-pushed
the
autodiff-lto-error
branch
from
b07b6fa to
1f700b6
Compare
This comment has been minimized.
This comment has been minimized.
ZuseZ4
force-pushed
the
autodiff-lto-error
branch
from
1f700b6 to
c8bae8c
Compare
Collaborator
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
This comment has been minimized.
This comment has been minimized.
Member
|
The first two commits LGTM. |
Collaborator
|
This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp. |
rustbot
added
the
T-bootstrap
This comment has been minimized.
This comment has been minimized.
ZuseZ4
force-pushed
the
autodiff-lto-error
branch
from
7080aed to
c8bae8c
Compare
Member
Author
|
Thanks, I'll leave the newer commits to another PR. @bors r=bjorn3 rollup |
Collaborator
bors
added
S-waiting-on-bors
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Nov 17, 2025
Error if an autodiff user does not set lto=fat Based on your feedback, I started to provide a nice error message for a lack of `lto=fat`, instead of us forcing it. In a next step, we should replace `RUSTFLAGS="-Zautodiff=Enable"` with another Cargo.toml setting, as discussed here: rust-lang#147487 (comment) As another improvement, we should also figure out why rlib builds do not properly obey the fat=lto setting. `@bjorn3`
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Nov 17, 2025
Error if an autodiff user does not set lto=fat Based on your feedback, I started to provide a nice error message for a lack of `lto=fat`, instead of us forcing it. In a next step, we should replace `RUSTFLAGS="-Zautodiff=Enable"` with another Cargo.toml setting, as discussed here: rust-lang#147487 (comment) As another improvement, we should also figure out why rlib builds do not properly obey the fat=lto setting. ``@bjorn3``
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Nov 17, 2025
Error if an autodiff user does not set lto=fat Based on your feedback, I started to provide a nice error message for a lack of `lto=fat`, instead of us forcing it. In a next step, we should replace `RUSTFLAGS="-Zautodiff=Enable"` with another Cargo.toml setting, as discussed here: rust-lang#147487 (comment) As another improvement, we should also figure out why rlib builds do not properly obey the fat=lto setting. ```@bjorn3```
bors
added a commit
that referenced
this pull request
Nov 17, 2025
Rollup of 6 pull requests Successful merges: - #147760 ([Debugger Visualizers] Unify `*-gnu` and `*-msvc` enum output) - #148505 (add larger test for `proc_macro` `FromStr` implementations) - #148855 (Error if an autodiff user does not set lto=fat) - #148958 (Run codegen tests on a 32-bit target in PR CI) - #149004 (compiletest: Avoid race condition in file deletion) - #149008 (triagebot: remove jsha from notifications for rustdoc HTML) r? `@ghost` `@rustbot` modify labels: rollup
JaclynCodes
added a commit
to JaclynCodes/rust
that referenced
this pull request
Nov 17, 2025
Error if an autodiff user does not set lto=fat Based on your feedback, I started to provide a nice error message for a lack of `lto=fat`, instead of us forcing it. In a next step, we should replace `RUSTFLAGS="-Zautodiff=Enable"` with another Cargo.toml setting, as discussed here: rust-lang#147487 (comment) As another improvement, we should also figure out why rlib builds do not properly obey the fat=lto setting. ````@bjorn3````
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Nov 17, 2025
Error if an autodiff user does not set lto=fat Based on your feedback, I started to provide a nice error message for a lack of `lto=fat`, instead of us forcing it. In a next step, we should replace `RUSTFLAGS="-Zautodiff=Enable"` with another Cargo.toml setting, as discussed here: rust-lang#147487 (comment) As another improvement, we should also figure out why rlib builds do not properly obey the fat=lto setting. `````@bjorn3`````
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Nov 17, 2025
Error if an autodiff user does not set lto=fat Based on your feedback, I started to provide a nice error message for a lack of `lto=fat`, instead of us forcing it. In a next step, we should replace `RUSTFLAGS="-Zautodiff=Enable"` with another Cargo.toml setting, as discussed here: rust-lang#147487 (comment) As another improvement, we should also figure out why rlib builds do not properly obey the fat=lto setting. ``````@bjorn3``````
bors
added a commit
that referenced
this pull request
Nov 17, 2025
Rollup of 11 pull requests Successful merges: - #148505 (add larger test for `proc_macro` `FromStr` implementations) - #148752 (Constify `ManuallyDrop::take`) - #148757 (Constify `mem::take`) - #148855 (Error if an autodiff user does not set lto=fat) - #148912 (add note to `lines` docs about empty str behavior) - #148958 (Run codegen tests on a 32-bit target in PR CI) - #148994 (Abi compatibility test cleanup) - #148999 (Tweak Motor OS linker preset, fix `remote-test-server` for Motor OS) - #149004 (compiletest: Avoid race condition in file deletion) - #149008 (triagebot: remove jsha from notifications for rustdoc HTML) - #149010 (compiletest: Remove the "wasm32-bare" alias for `wasm32-unknown-unknown`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Nov 17, 2025
Rollup merge of #148855 - ZuseZ4:autodiff-lto-error, r=bjorn3 Error if an autodiff user does not set lto=fat Based on your feedback, I started to provide a nice error message for a lack of `lto=fat`, instead of us forcing it. In a next step, we should replace `RUSTFLAGS="-Zautodiff=Enable"` with another Cargo.toml setting, as discussed here: #147487 (comment) As another improvement, we should also figure out why rlib builds do not properly obey the fat=lto setting. ```````@bjorn3```````
github-actions bot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Nov 17, 2025
Rollup of 11 pull requests Successful merges: - rust-lang/rust#148505 (add larger test for `proc_macro` `FromStr` implementations) - rust-lang/rust#148752 (Constify `ManuallyDrop::take`) - rust-lang/rust#148757 (Constify `mem::take`) - rust-lang/rust#148855 (Error if an autodiff user does not set lto=fat) - rust-lang/rust#148912 (add note to `lines` docs about empty str behavior) - rust-lang/rust#148958 (Run codegen tests on a 32-bit target in PR CI) - rust-lang/rust#148994 (Abi compatibility test cleanup) - rust-lang/rust#148999 (Tweak Motor OS linker preset, fix `remote-test-server` for Motor OS) - rust-lang/rust#149004 (compiletest: Avoid race condition in file deletion) - rust-lang/rust#149008 (triagebot: remove jsha from notifications for rustdoc HTML) - rust-lang/rust#149010 (compiletest: Remove the "wasm32-bare" alias for `wasm32-unknown-unknown`) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on your feedback, I started to provide a nice error message for a lack of
lto=fat, instead of us forcing it.In a next step, we should replace
RUSTFLAGS="-Zautodiff=Enable"with another Cargo.toml setting, as discussed here: #147487 (comment)As another improvement, we should also figure out why rlib builds do not properly obey the fat=lto setting.
@bjorn3